feat(metrics): Add and use timer guard#491
Open
lcian wants to merge 9 commits into
Open
Conversation
lcian
changed the title
This comment has been minimized.
This comment has been minimized.
lcian
changed the title
lcian
commented
Jun 5, 2026
|
|
||
| /// Changes the behavior of this guard to always record the metric | ||
| /// with `success:true`, even on drop. | ||
| pub fn success(mut self) -> Self { |
Member
Author
There was a problem hiding this comment.
We don't need this atm but I can see some cases where this would realistically be useful, e.g. on an idempotent function that shortcircuits as an optimization.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matt-codecov
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issues flagged in #485 by introducing
objectstore_metrics::timer!that returns aTimerGuardwhich records elapsed time on drop or explicit consumption withrecord(). See code for API and more info.Also updates all the existing usages of timing metrics to use of this new API.
Close FS-375